Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge_tools: create builtin merge editor #2118

Merged
merged 1 commit into from
Sep 18, 2023
Merged

merge_tools: create builtin merge editor #2118

merged 1 commit into from
Sep 18, 2023

Conversation

arxanas
Copy link
Contributor

@arxanas arxanas commented Aug 19, 2023

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

cli/src/cli_util.rs Outdated Show resolved Hide resolved
@arxanas arxanas force-pushed the arxanas/difftool-3 branch 2 times, most recently from befefab to e932658 Compare August 21, 2023 03:57
@arxanas arxanas force-pushed the arxanas/difftool-2 branch from 144b08d to a06f030 Compare August 21, 2023 03:57
@arxanas arxanas force-pushed the arxanas/difftool-3 branch from e932658 to 18b3d7a Compare August 22, 2023 04:34
@arxanas arxanas force-pushed the arxanas/difftool-2 branch from a06f030 to 715b590 Compare August 22, 2023 04:34
@arxanas arxanas force-pushed the arxanas/difftool-3 branch from 18b3d7a to b522168 Compare August 23, 2023 04:20
@arxanas arxanas force-pushed the arxanas/difftool-2 branch from 715b590 to a375859 Compare August 23, 2023 04:20
@arxanas arxanas changed the title merge_tools: create internal mergetool merge_tools: create builtin mergetool Aug 27, 2023
@arxanas arxanas force-pushed the arxanas/difftool-2 branch from a375859 to ee77c67 Compare August 27, 2023 13:49
@arxanas arxanas force-pushed the arxanas/difftool-3 branch 2 times, most recently from d69c2f1 to 875c24f Compare August 27, 2023 15:43
@arxanas arxanas changed the title merge_tools: create builtin mergetool merge_tools: create builtin merge editor Aug 28, 2023
@arxanas arxanas force-pushed the arxanas/difftool-3 branch from 875c24f to f5426d2 Compare August 29, 2023 21:13
@arxanas arxanas force-pushed the arxanas/difftool-2 branch from 3e26b49 to 82f2e6b Compare August 29, 2023 21:13
@arxanas arxanas force-pushed the arxanas/difftool-3 branch from f5426d2 to c2dde80 Compare August 30, 2023 08:55
@arxanas arxanas force-pushed the arxanas/difftool-2 branch from 82f2e6b to 5dd2cfa Compare August 30, 2023 08:55
Base automatically changed from arxanas/difftool-2 to main August 30, 2023 09:38
@martinvonz
Copy link
Member

@arxanas, let me know which of your PRs are ready for review. This one seems to be at the bottom of the stack, but GitHub says it has changes conflicting with main, so maybe it's not actually ready?

@arxanas
Copy link
Contributor Author

arxanas commented Aug 31, 2023

@martinvonz The PRs marked as ready for review are ready. The conflict warning in GitHub can be misleading — this stack actually rebases without introducing any conflicts.

@arxanas arxanas force-pushed the arxanas/difftool-3 branch from c2dde80 to b604a2d Compare August 31, 2023 16:29
cli/src/merge_tools/builtin.rs Outdated Show resolved Hide resolved
cli/src/merge_tools/builtin.rs Outdated Show resolved Hide resolved
cli/src/merge_tools/builtin.rs Outdated Show resolved Hide resolved
cli/src/merge_tools/builtin.rs Outdated Show resolved Hide resolved
@arxanas arxanas marked this pull request as draft September 6, 2023 10:24
@arxanas arxanas marked this pull request as ready for review September 17, 2023 20:46
cli/src/merge_tools/builtin.rs Outdated Show resolved Hide resolved
@arxanas arxanas enabled auto-merge (rebase) September 18, 2023 04:10
@arxanas arxanas merged commit 393b035 into main Sep 18, 2023
15 checks passed
@arxanas arxanas deleted the arxanas/difftool-3 branch September 18, 2023 04:33
@martinvonz
Copy link
Member

I have no idea why, but I had to force a rescan of the CLA using an internal web page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants