-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jj diffs --stat option #2106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you!
and maybe some tests..
Yes, please :)
Also, please squash the second commit into the first and address comments by amending the commit. See https://github.com/martinvonz/jj/blob/main/docs/contributing.md#code-reviews.
Thanks for fixing. Will there be a test or two as well? :) They would probably belong in https://github.com/martinvonz/jj/blob/main/cli/tests/test_diff_command.rs |
Ah, thanks for the pointer to where the tests are. I'll figure out a way to add some tests... |
Ok, added some tests (and of course found a new bugs)... if there are other corner cases you can think of let me know and I'll add more tests... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks again. Feel free to merge once you've resolved the remaining comments.
49c04c3
to
521f0cb
Compare
This is a first cut at #2066. It needs a better way of getting the terminal width (hardcoded for now to 120) and maybe some tests... I did a few visual comparisons to
git diff
and it looks like it works...Checklist
If applicable:
CHANGELOG.md