Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configs: add the ability to disable paging altogether via ui.paginate #2035

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

mbStavola
Copy link
Contributor

This was a bit of a chance for me to play with jj a bit, so feel free to ignore 😄

I was basically frustrated with having to pass in --no-pager constantly and stumbled upon this PR where I saw that a ui.paginate option was considered and removed. I felt like adding it back might be a tiny, but helpful change for others like me.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (src/config-schema.json)
  • I have added tests to cover my changes

@google-cla
Copy link

google-cla bot commented Aug 11, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mbStavola mbStavola force-pushed the push-xtxnqrqqxwsx branch 2 times, most recently from 377e164 to 723ac93 Compare August 11, 2023 04:22
Copy link
Member

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

CHANGELOG.md Outdated Show resolved Hide resolved
cli/src/config-schema.json Outdated Show resolved Hide resolved
docs/config.md Outdated Show resolved Hide resolved
cli/src/ui.rs Show resolved Hide resolved
cli/src/ui.rs Outdated Show resolved Hide resolved
cli/src/ui.rs Outdated Show resolved Hide resolved
@martinvonz martinvonz enabled auto-merge (rebase) August 11, 2023 16:25
@martinvonz martinvonz disabled auto-merge August 11, 2023 16:26
@martinvonz
Copy link
Member

I've added you as a contributor. Feel free to merge at will.

@mbStavola mbStavola merged commit 4760b56 into jj-vcs:main Aug 11, 2023
@mbStavola mbStavola deleted the push-xtxnqrqqxwsx branch August 11, 2023 16:45
@mbStavola
Copy link
Contributor Author

I've added you as a contributor. Feel free to merge at will.

Thank you, looking forward to contributing to jj more 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants