-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add doc comparing jj to Sapling (#1708) #1716
Conversation
853ac3b
to
4d8d65b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but it would be valuable if a Meta employee also took a look at it.
Mostly look good to me. There are some future plans that might count as noticeable differences but I think it's fine not documenting them until they are available:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. Just two minor comments.
Thanks for reviewing! Yes, I think it's better to document that once it's done. Feel free to send a PR when it is.
That actually sounds similar to what we're thinking of doing with jj at Google. I hope we'll be able to do that by replacing the working copy implementation (it's not currently a trait, but it will be soon). So we'll have the default working-copy implementation, which is used outside of Google, and we'll have a custom CitC-aware implementation internally. The right working-copy implementation will be loaded depending on the repo, just like we load the right commit backend etc. So maybe the main difference will be that your VFS-integration will be open-sourced.
Ah, that's a good point. I think it's probably too rare that users care about NFS support that it's worth mentioning. |
4d8d65b
to
be5de69
Compare
If jj supports Git tags, you could mention that Sapling does not support Git tags. |
be5de69
to
dcf4bbc
Compare
Thanks, but jj has very limited support (you can see and specify revisions by tag name, but you can't create tags), so I don't think it's worth mentioning. |
Checklist
If applicable:
CHANGELOG.md