Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a config edit command to open jj config in editor #1003

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Add a config edit command to open jj config in editor #1003

merged 1 commit into from
Jan 12, 2023

Conversation

dbarnett
Copy link
Contributor

@dbarnett dbarnett commented Jan 11, 2023 •
edited
Loading

Part of #531 to define the overall config command.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have added tests to cover my changes

@dbarnett dbarnett force-pushed the push-4c07f66b034747e2ac227c39bdf4730d branch 2 times, most recently from 2e41c30 to a093cc2 Compare January 11, 2023 04:47
@dbarnett
Copy link
Contributor Author

Weird, sometimes the cargo clippy check here finds issues that don't turn up locally when I run cargo clippy --all-features --workspace --all-targets -- -D warnings. Maybe it's running a newer version of something? Anyway, think I got it fixed.

@martinvonz
Copy link
Member

Weird, sometimes the cargo clippy check here finds issues that don't turn up locally when I run cargo clippy --all-features --workspace --all-targets -- -D warnings. Maybe it's running a newer version of something? Anyway, think I got it fixed.

The one running here is the latest stable version, which is currently 1.66.1. I think you can use rustup update to upgrade your toolchains. You may want to run rustup default stable to make that the default.

martinvonz
martinvonz reviewed Jan 11, 2023
View reviewed changes
src/commands.rs Outdated Show resolved Hide resolved
src/commands.rs Outdated Show resolved Hide resolved
src/commands.rs Outdated Show resolved Hide resolved
@dbarnett dbarnett force-pushed the push-4c07f66b034747e2ac227c39bdf4730d branch 2 times, most recently from 8979c28 to 2a1573f Compare January 12, 2023 05:41
@dbarnett dbarnett requested a review from martinvonz January 12, 2023 05:44
martinvonz
martinvonz approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@dbarnett dbarnett force-pushed the push-4c07f66b034747e2ac227c39bdf4730d branch from 2a1573f to f3ef124 Compare January 12, 2023 06:24
@dbarnett
Add a config edit command to open jj config in editor
309e61a 
Part of #531 to define the overall `config` command.
@dbarnett dbarnett force-pushed the push-4c07f66b034747e2ac227c39bdf4730d branch from f3ef124 to 309e61a Compare January 12, 2023 06:28
@dbarnett dbarnett merged commit e6b3b9c into main Jan 12, 2023
@dbarnett dbarnett deleted the push-4c07f66b034747e2ac227c39bdf4730d branch January 12, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinvonz martinvonz martinvonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbarnett @martinvonz