-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zsh completion instructions incorrect, maybe #1393
Comments
Yes, it look like that changed in clap-rs/clap@0f3e729, which was released in FYI, this seems to work for me with the new version: autoload -U compinit
compinit
source <(jj support completion --zsh) |
We need 1.64 to bump `clap` to `4.1`. We don't really need to upgrade to that, but being on an older version causes minor confusions like #1393. Rust 1.64 is very close to 6 months old at this point.
This includes some changes to error messages. Also, the Zsh shell completion script is now simpler to source. Fixes #1393.
We need 1.64 to bump `clap` to `4.1`. We don't really need to upgrade to that, but being on an older version causes minor confusions like #1393. Rust 1.64 is very close to 6 months old at this point.
This includes some changes to error messages. Also, the Zsh shell completion script is now simpler to source. Fixes #1393.
We need 1.64 to bump `clap` to `4.1`. We don't really need to upgrade to that, but being on an older version causes minor confusions like #1393. Rust 1.64 is very close to 6 months old at this point.
This includes some changes to error messages. Also, the Zsh shell completion script is now simpler to source. Fixes #1393.
We need 1.64 to bump `clap` to `4.1`. We don't really need to upgrade to that, but being on an older version causes minor confusions like #1393. Rust 1.64 is very close to 6 months old at this point.
Yup! The completion seemed fine, it was just the README instruction was missed. Thanks |
We upgraded to clap 4.1 in 8f1dc49 (cargo: upgrade to clap 4.1, 2023-03-17), and the pipe to `sed` was removed in the README.md file in that same commit. However the documentation was not updated in mod.rs, which leads us to give the obsolete (now incorrect) advice when we run `jj util completion --help`. See jj-vcs#1393.
We upgraded to clap 4.1 in 8f1dc49 (cargo: upgrade to clap 4.1, 2023-03-17), and the pipe to `sed` was removed in the README.md file in that same commit. However the documentation was not updated in mod.rs, which leads us to give the obsolete (now incorrect) advice when we run `jj util completion --help`. See #1393.
I think maybe the README instructions didn't get updated for a recent change -- or else the completion output changed unexpectedly.
The README says to strip the last line of
jj support completion --zsh
withsed
, but that now removes the closingfi
of the last if statement:The text was updated successfully, but these errors were encountered: