Skip to content

Commit

Permalink
demos: fixup, working_copy.png wasn't regenerated properly
Browse files Browse the repository at this point in the history
The "redacted output" wasn't properly redacted.

Also removed extraneous comment, and added a comment since
the new PNGs are larger than I expected.
  • Loading branch information
ilyagr committed Sep 6, 2024
1 parent 6ea46b9 commit 8f603f1
Show file tree
Hide file tree
Showing 4 changed files with 43 additions and 41 deletions.
2 changes: 0 additions & 2 deletions demos/helpers.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ run_command() {

run_command_output_redacted() {
echo "\$ $@"
# `bash` often resets $COLUMNS, so we also
# allow $RUN_COMMAND_COLUMNS
eval "$@" > /dev/null 2>&1
echo -e "\033[0;90m... (output redacted) ...\033[0m"
}
Expand Down
7 changes: 7 additions & 0 deletions demos/run_scripts.sh
Original file line number Diff line number Diff line change
Expand Up @@ -70,4 +70,11 @@ for script in "$@"; do
-colors 63 -background black -resize 100% \
"$script_base".png \
|| true
# TODO/FIXME: The above command doesn't seem to work properly;
# the PNG files end up larger than they should be and are RGB
# as opposed to expected indexed 63-color. This is caused by
# https://github.com/martinvonz/jj/commit/6d573ef6d7a45151495de18b6f4c5063ce39f6bd
# and
# https://github.com/martinvonz/jj/commit/42dee7d08ce8e362cf9d44f844b25e001b6ac94f
# and needs debugging of ImageMagick invocations.
done
Binary file modified demos/working_copy.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading

0 comments on commit 8f603f1

Please sign in to comment.