Fix MigrateRunner._createMigrateTableIfNotExists #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiradp
approved these changes
Dec 10, 2019
|
@sean-krail @tmercswims - I'm going to merge this PR's branch to my branch for #1. I can then tell my package json to point to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as noppoMan#72
_createMigrateTableIfNotExistsnow works when there are more than 100 tables (DynamoDB has a soft limit of 256 tables per region). Say you have 101 tablestable1throughtable100and your migration history table's name istable101, the function thinks the migration history table doesn't exist, tries to create it, and then throws aResourceInUseExceptionsince it really does exist.Changes
_createMigrateTableIfNotExitsto_createMigrateTableIfNotExists_createMigrateTableIfNotExistsnow uses describeTable instead of listTables to figure out if the migration history table already exists. This change was made since listTables uses pagination which defaults to 100 and describeTable can fetch one table by name.