feat(statistics): add pre call test interface #2578
Conversation
modules/statistics/PreCallTest.ts
Outdated
| throughput: number; // Maximum bandwidth reached in kbps (kilo bits per second). | ||
| fractionalLoss: number; // Packet loss percentage over all the test traffic. | ||
| rtt: number; // Round trip time in milliseconds. | ||
| jitter: number; |
modules/statistics/PreCallTest.ts
Outdated
| * @returns {Promise<PreCallResult | string>} - A Promise that resolves with the test results or rejects with an error message. | ||
| */ | ||
| export default async function runPreCallTest(iceServers: Array<IceServer>): Promise<PreCallResult | string> { | ||
| // On initialization, the PreCallTest object simply does some checks and some browsers verifications, |
There was a problem hiding this comment.
Can we have some static init() method perhaps? It could keep track of whether it has already run and avoid doing the work over and oer again.
There was a problem hiding this comment.
As I see the API, it is expected that you could run this multiple times. For instance in the middle of the meeting you could run a test to check how your connection is performing, sort of an on demand test for participants that are concerned about their connection status.
There was a problem hiding this comment.
I meant the initial check we can reuse, not the whole test. This "init" thing would do just that.
There was a problem hiding this comment.
not sure I follow completely, you mean something like?
const init = (function() = { preCallTest = new PreCallTest()) })() And basically initialize on import? so I can remove the check from runPreCallTest?
There was a problem hiding this comment.
No, I mean something like:
await PrecallTest.globalInit();
const p = new PreCallTest();
...
modules/statistics/PreCallTest.ts
Outdated
| preCallTest || (preCallTest = new PreCallTest()) | ||
|
|
||
| return new Promise((resolve, reject) => { | ||
| // It's not explicitly stated in the code, but if message is not null, something went wrong, |
There was a problem hiding this comment.
Let's change the library please, this is not a good API.
There was a problem hiding this comment.
I agree, just didn't want to mess with the library to much, cause I don't know the extent of the changes required. Should I start a refactoring effort on precall_test?
There was a problem hiding this comment.
By the looks we don't need a full refactor, but a better way to report errors, to start with.
There was a problem hiding this comment.
Added a new version with a promise based interface
webpack-shared-config.js
Outdated
| @@ -80,8 +80,8 @@ module.exports = (minimize, analyzeBundle) => { | |||
| }, | |||
| performance: { | |||
| hints: minimize ? 'error' : false, | |||
| maxAssetSize: 1.08 * 1024 * 1024, | |||
| maxEntrypointSize: 1.08 * 1024 * 1024 | |||
| maxAssetSize: 1.09 * 1024 * 1024, | |||
There was a problem hiding this comment.
Let's bump it to 1.25 to avoid having to do it one by one.
No description provided.