Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(JitsiTranscriptionStatus): the status values are upper case #2568

Merged
merged 1 commit into from
Sep 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions JitsiTranscriptionStatus.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ describe( "/JitsiTranscriptionStatus members", () => {
} = exported;

it( "known members", () => {
expect( ON ).toBe( 'on' );
expect( OFF ).toBe( 'off' );
expect( ON ).toBe( 'ON' );
expect( OFF ).toBe( 'OFF' );

expect( JitsiTranscriptionStatus ).toBeDefined();

expect( JitsiTranscriptionStatus.ON ).toBe( 'on' );
expect( JitsiTranscriptionStatus.OFF ).toBe( 'off' );
expect( JitsiTranscriptionStatus.ON ).toBe( 'ON' );
expect( JitsiTranscriptionStatus.OFF ).toBe( 'OFF' );
} );

it( "unknown members", () => {
Expand Down
4 changes: 2 additions & 2 deletions JitsiTranscriptionStatus.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@ export enum JitsiTranscriptionStatus {
/**
* The transcription is on.
*/
ON = 'on',
ON = 'ON',

/**
* The transcription is off.
*/
OFF = 'off'
OFF = 'OFF'
}

// exported for backward compatibility
Expand Down
4 changes: 2 additions & 2 deletions types/hand-crafted/JitsiTranscriptionStatus.d.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export enum JitsiTranscriptionStatus {
ON = 'on',
OFF = 'off'
ON = 'ON',
OFF = 'OFF'
}