feat(build) migrate to Webpack 5 #9716
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flow rules are now separate from the default ones.
In preparation for Webpack 5.
saghul
force-pushed
the
ts
branch
2 times, most recently
from
98ef4b0
to
1453597
Compare
quitrk
reviewed
Aug 16, 2021
| */ | ||
| function getPerformanceHints(size) { | ||
| function getPerformanceHints(options, size) { |
There was a problem hiding this comment.
calls to this only pass the size parameter
quitrk
reviewed
Aug 16, 2021
| } | ||
|
|
||
| module.exports = (_env, argv) => { | ||
| const analyzeBundle = Boolean(process.env.ANALYZE_BUNDLE); |
There was a problem hiding this comment.
is there a reason we don't extract this up top rather than passing it to getBundleAnalyzerPlugin and getPerformanceHints?
There was a problem hiding this comment.
Both of those groups of options rely on knowing the mode (prod or dev) and in Webpack 5 that is accomplished by exporting a function instead and checking the argv object. Hence I extracted and passed down the options where necessary.
There was a problem hiding this comment.
263 },
264 plugins: [
265 ...config.plugins,
266 ...getBundleAnalyzerPlugin('analytics-ga')
267 ],
268 performance: getPerformanceHints(5 * 1024)
269 }),cant find in webpack.config.js
can you give me a hint
web /srv/jitsi-meet # cat -n webpack.config.js | grep -A 5 -B 5 module.exports
202 '.json'
203 ]
204 }
205 };
206
207 module.exports = [
208 Object.assign({}, config, {
209 entry: {
210 'app.bundle': './app.js'
211 },
212 plugins: [
--
313 || path.endsWith('.wasm')) {
314
315 return path;
316 }
317
318 const configs = module.exports;
319
320 /* eslint-disable array-callback-return, indent */
321
322 if ((Array.isArray(configs) ? configs : Array(configs)).some(c => {
323 if (path.startsWith(c.output.publicPath)) {
This was referenced Oct 1, 2021
|
Superseded by #10119 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for introducing TypeScript.