Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move STUN/TURN to IANA-assigned ports - 3478 and 5349 (TLS) #6172

Merged
merged 3 commits into from
Jul 7, 2020

Conversation

Yetangitu
Copy link
Contributor

See #5714 (comment)

This change moves STUN/TURN to the IANA-assigned ports, 3478 and 5349 (TLS)

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@damencho
Copy link
Member

Can you grep through the whole repo for 4446, there are more places you are missing, like
https://github.com/jitsi/jitsi-meet/blob/master/doc/debian/jitsi-meet/jitsi-meet.conf#L10

@damencho
Copy link
Member

Thank you

@Yetangitu
Copy link
Contributor Author

Can you grep through the whole repo for 4446, there are more places you are missing, like
https://github.com/jitsi/jitsi-meet/blob/master/doc/debian/jitsi-meet/jitsi-meet.conf#L10

4446 does not occur anywhere in the repo but 4445 does, in that example you cited and one other file:

$ git grep 4445
debian/jitsi-meet-turnserver.postinst:                echo "turnserver is listening on tcp 4445 as other nginx sites use port 443"
debian/jitsi-meet-turnserver.postinst:                sed -i 's/"443"/"4445"/g' $PROSODY_HOST_CONFIG
doc/debian/jitsi-meet/jitsi-meet.conf:        server 127.0.0.1:4445;

I changed these to 5349 in the PR, assuming that it is the TLS-encrypted version of STUN/TURN which is to be used. If not it should be 3478 - in fact that port can be used both for unencrypted as well as encrypted traffic, at least with Coturn (from man turnserver):

       -p, --listening-port
              TURN listener port for UDP and TCP listeners (Default: 3478).  Note: actually, TLS & DTLS sessions can connect  to  the  "plain"  TCP  &  UDP
              port(s), too - if allowed by configuration.

@damencho damencho self-assigned this May 27, 2020
@damencho damencho merged commit 29c16e4 into jitsi:master Jul 7, 2020
quuu added a commit to NooksApp/jitsi-meet that referenced this pull request Jul 11, 2020
* fix: Uses room jids for the lobby notifications.

* feat: lobby related notifications

* deps: update clean-css (reland)

Fix the incorrect paths (was a breaking change in version 4) by using the
`--skip-rebase` cli option.

* fix(dialout) whitelist dialout flag

* fixed non valid json turkish language file

* Move STUN/TURN to IANA-assigned ports - 3478 and 5349 (TLS) (jitsi#6172)

* Move STUN/TURN to IANA-assigned ports - 3478 and 5349 (TLS)

* Change remaining references to TURNS port from 4445 to 5349

* Change back TURNS to 443

* Update main.json with missing KnockingParticipantList string (jitsi#7246)

Adding future translation possibilities

* Update main-fr.json

Fix translate FR and add "Security" translations

* Update KnockingParticipantList.js

In order to translate the title.. Pull request jitsi#7246

* Update main-fr.json

Translate for "Add" in security option

* Update main-fr.json

Some translations for "invite"

* Update mod_muc_poltergeist.lua

Add avatar to user context so it is picked by the web interface

* Update main-fr.json

Translation 'prejoin'

* deps: [email protected]

* android: added configuration for user CA root trust

* fix(prejoin): Don't add video track to connection on start if video muted

* config: add flag to disable the E2EE support

 This is useful for testing insertable streams related issues.

* deps: lib-jitsi-meet@latest

* chore(deps): update lib-jitsi-meet to latest

* rn,flags: add ability to override resolution using a flag

Also, use the configured resolution to set it as the max received frame size.

* rn: set default resolution to 360p (experiment)

* conference: fix not applying max recv constraints

They also need to be applied when changing conferences.

* deps: jitsi/[email protected]

* config: fix typo

* deps: lib-jitsi-meet@latest

* misc: add script to update LJM to the latest commit

* fix(SecurityDialog): Fix password action spacing

* feat(prejoin) cache media start options when on prejoin screen

* feat(prejoin) Expose prejoin app

* fix: Fixes import of moved function.

* analytics: avoid error log when there are no handlers

* config: Add option to set preferred audio bitrate. (jitsi#7072)

The maxaveragebitrate parameter to be used by Opus can be configured
through the new opusMaxAvgBitrate config option. Values are restricted
by Opus to integers between 6000 to 510000. Works for non-p2p only.

move option to Audio section, add documentation

Co-authored-by: plokta <[email protected]>

Co-authored-by: damencho <[email protected]>
Co-authored-by: Bettenbuk Zoltan <[email protected]>
Co-authored-by: Saúl Ibarra Corretgé <[email protected]>
Co-authored-by: Tudor-Ovidiu Avram <[email protected]>
Co-authored-by: Cem Ibrahim ARI <[email protected]>
Co-authored-by: Frank de Lange <[email protected]>
Co-authored-by: Florian <[email protected]>
Co-authored-by: Maxence Dalmais <[email protected]>
Co-authored-by: motiwardi <[email protected]>
Co-authored-by: Vlad Piersec <[email protected]>
Co-authored-by: Jaya Allamsetty <[email protected]>
Co-authored-by: ALAGBE Sola <[email protected]>
Co-authored-by: Mihai Uscat <[email protected]>
Co-authored-by: plokta <[email protected]>
Co-authored-by: plokta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants