Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Native accessibility fixes #5825

Merged
merged 8 commits into from
Apr 10, 2020
Merged

React Native accessibility fixes #5825

merged 8 commits into from
Apr 10, 2020

Conversation

MarcoZehe
Copy link
Contributor

This pull request adds various commits to fix issues mentioned in #5817 .

  • The buttons are buttons.
  • Toggled on buttons are selected.
  • The toolbox is a tool bar.
  • The bottom sheet is a menu.

Things still unsolved:

  • Hints are not yet assigned. Looks like they are the same as the visible label when not toggled in most cases, so don't actually add any value for screen reader users. I might drop this.
  • The thing that is the area where one clicks to close is not yet a button and has no label. I haven't found that particular component yet.
  • Same goes for the unlabeled area before the video element in the swiping order.

These changes are untested, since I cannot actually build for react native or test on a device at the moment. I am leaving this open for edits by maintainers so you can augment to these proposed changes and make corrections.

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@paweldomas paweldomas merged commit e32f367 into jitsi:master Apr 10, 2020
@luixxiul luixxiul added accessibility Issue related to accessibility topics/handicapped users info:cla-signed The CLA has been signed labels May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issue related to accessibility topics/handicapped users info:cla-signed The CLA has been signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants