Add stopTracks helper to LocalStream to replace deprecated stream.stop() #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| track.stop(); | ||
| }) | ||
| }; | ||
|
|
There was a problem hiding this comment.
Could you please indent with four space to keep code consistent.
There was a problem hiding this comment.
And we need to check here whether stop method actually exist. As it is not supported in IE.
|
It seem its not only the stream stop. I was playing all day with ended/active and onended/oninactive, and changes needed to handle themasys. Seems it is working but several situations still fail when running the tests. Testing with chrome stable, canary, firefox and by hand on safari. I can take the PR and work over it, thanks. |
|
@damencho thanks, let me know if I can be of any help |
damencho
added a commit
that referenced
this pull request
Nov 2, 2015
… Based on previous code and inspired by PR #390.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome 47 is deprecating MediaStream.stop(), to be replaced with MediaStreamTrack.stop()
See https://developers.google.com/web/updates/2015/07/mediastream-deprecations?hl=en