Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance volume slider appearance #15105

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Enhance volume slider appearance #15105

wants to merge 5 commits into from

Conversation

thepiyush-303
Copy link
Contributor

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@thepiyush-303
Copy link
Contributor Author

Hello @jitsi-jenkins ,
Can you please review the changes?

@thepiyush-303
Copy link
Contributor Author

@damencho
can you please review the changes?

@damencho
Copy link
Member

If we are changing that we want it to look like this:

Screen.Recording.2024-10-10.at.8.07.50.AM.mov

The current look of the slider is closer to this one ^ than the changes you propose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thepiyush-303 @jitsi-jenkins @damencho