Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(participants-pane) consolidate moeration options #11891

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

saghul
Copy link
Member

@saghul saghul commented Jul 20, 2022

They are now under a single "Moderator" button.
Screenshot 2022-07-20 at 15 57 30
Screenshot 2022-07-20 at 15 54 29
Screenshot 2022-07-20 at 15 51 53

They are now under a single "Moderator" button.
@saghul
Copy link
Member Author

saghul commented Jul 20, 2022

I'm not sure what to do about the config options to hide these buttons. Should we rename it to say "hideModeratorButton" ? Does anyone see the need for having individual hiding options if they are under the same menu? I'd say no...

@shawnchin
Copy link
Contributor

shawnchin commented Jul 20, 2022

Apologies for butting in.

Not sure how common a use case this is, but in our setup most of our users get moderator privileges and the "Allow attendees to:" actions sometimes cause confusion because others can still unmute themselves and enable video (because they are also moderator).

Given a choice, I would enable the "Mute all" and "Stop everyone's video" options but hide the other AV moderation actions to avoid confusion.

But not a big deal if it's all or nothing.

@robertpin
Copy link
Contributor

The web part LGTM. I'll leave the native to Calin

@saghul
Copy link
Member Author

saghul commented Jul 21, 2022

Apologies for butting in.

Not sure how common a use case this is, but in our setup most of our users get moderator privileges and the "Allow attendees to:" actions sometimes cause confusion because others can still unmute themselves and enable video (because they are also moderator).

Given a choice, I would enable the "Mute all" and "Stop everyone's video" options but hide the other AV moderation actions to avoid confusion.

But not a big deal if it's all or nothing.

Thanks for the feedback! Do you think changing the text would help? Something like "Allow non-moderators to: ..."

@shawnchin
Copy link
Contributor

Changing to something like "Allow non-moderators to: ..." would certainly help! 👍

@mihhu
Copy link
Member

mihhu commented Jul 21, 2022

I'm not sure what to do about the config options to hide these buttons. Should we rename it to say "hideModeratorButton" ? Does anyone see the need for having individual hiding options if they are under the same menu? I'd say no...

I agree that hideMoreActionsButton and hideMuteAllButton can be deprecated in favour of a single more comprehensive option. I'd change the name though, if we plan to include the hideModeratorSettingsTab functionality (hideModeratorOptions?). Otherwise, there is no reason for it to stay in the participantsPane config.

@saghul
Copy link
Member Author

saghul commented Jul 21, 2022

I'm not sure what to do about the config options to hide these buttons. Should we rename it to say "hideModeratorButton" ? Does anyone see the need for having individual hiding options if they are under the same menu? I'd say no...

I agree that hideMoreActionsButton and hideMuteAllButton can be deprecated in favour of a single more comprehensive option. I'd change the name though, if we plan to include the hideModeratorSettingsTab functionality (hideModeratorOptions?). Otherwise, there is no reason for it to stay in the participantsPane config.

I agree. Now, in terms of backwards compatibility, how would you translate the old options into the new one?

@mihhu
Copy link
Member

mihhu commented Jul 21, 2022

I agree. Now, in terms of backwards compatibility, how would you translate the old options into the new one?

Let's enforce the interfaceConfig.SETTINGS_SECTIONS in the cases where we get opposite values and see whether it's relevant to keep the hideMuteAllButton: false working when there's no moderation button.

@Calinteodor
Copy link
Contributor

The web part LGTM. I'll leave the native to Calin

Native part LGTM.

@saghul
Copy link
Member Author

saghul commented Jul 22, 2022

Thanks! I'll add the backwards compat bits before merge.

@saghul saghul marked this pull request as draft August 16, 2022 14:19
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 4, 2023
@github-actions github-actions bot closed this Sep 15, 2023
@saghul saghul reopened this Sep 15, 2023
@saghul saghul added confirmed Confirmed bug, should not go stale and removed stale labels Sep 15, 2023
@Calinteodor
Copy link
Contributor

Please fix conflicts, if this is ready for review. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed Confirmed bug, should not go stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants