Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra colibri channels allocated #49

Closed
bgrozev opened this issue Mar 3, 2014 · 3 comments
Closed

Extra colibri channels allocated #49

bgrozev opened this issue Mar 3, 2014 · 3 comments
Assignees

Comments

@bgrozev
Copy link
Member

bgrozev commented Mar 3, 2014

In the beginning of a conference unnecessary colibri channels are allocated. For example, in a conference of two the focus requests a total of three pairs of channels (3 audio, 3 video). I observed the following: Initially the focus requests 2 audio and 2 video channels. The bridge replies setting channel ids. Something like:

<content name="audio">
<channel direction="recvonly" expire="15" id="3d3a45dfa9b84087" initiator="true" rtp-level-relay-type="mixer">...</channel>
<channel direction="recvonly" expire="15" id="fa5e08e307baa8d9" initiator="true" rtp-level-relay-type="mixer">...</channel>
</content>
<content name="video">
<channel expire="15" id="49a8168ab3843f8" initiator="true" rtp-level-relay-type="translator">...</channel>
<channel expire="15" id="30f1869daed6e04e" initiator="true" rtp-level-relay-type="translator">...</channel>
</content>

The focus then appears to use only one of the channels for each content, and requests new ones:

<content name="audio">
<channel id="3d3a45dfa9b84087" expire="15" initiator="true">...</channel>
<channel expire="15" initiator="true"/>
</audio>
<content name="video">
<channel id="49a8168ab3843f8" expire="15" initiator="true">...</channel>
<channel expire="15" initiator="true"/>
</content>
@fippo
Copy link
Member

fippo commented Mar 4, 2014

I think that is the focus updating it's own channel information, not requesting a new one?
The channel id is the first one from the set. Further channels will be used when the focus gets a session-accept from the client.

Code is at https://github.com/jitsi/jitmeet/blob/master/libs/colibri.js#L302

@bgrozev
Copy link
Member Author

bgrozev commented Mar 4, 2014

Updating its own channel information with the first 'channel' element, right? But, the second 'channel' element, not having an ID, is a request for a new channel. Or am I missing something?

@fippo
Copy link
Member

fippo commented Mar 5, 2014

nope, that appears to have been a copy-paste bug. Thanks for noticing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants