Merge pull request #1114 from jitsi/fix_page_reload_log

Log the page reload from one place
jitsi · Nov 6, 2016 · 38e4444 · 38e4444
2 parents 02495e3 + d256bc3
commit 38e4444
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/conference.js b/conference.js
@@ -370,11 +370,6 @@ class ConferenceConnector {
 
         case ConferenceErrors.FOCUS_LEFT:
         case ConferenceErrors.VIDEOBRIDGE_NOT_AVAILABLE:
-            // Log the page reload event
-            // FIXME (CallStats - issue) this event will not make it to
-            // the CallStats, because the log queue is not flushed, before
-            // "fabric terminated" is sent to the backed
-            APP.conference.logEvent('page.reload');
             // FIXME the conference should be stopped by the library and not by
             // the app. Both the errors above are unrecoverable from the library
             // perspective.

diff --git a/modules/UI/reload_overlay/PageReloadOverlay.js b/modules/UI/reload_overlay/PageReloadOverlay.js
@@ -116,6 +116,13 @@ export default {
         if (!overlay) {
             overlay = new PageReloadOverlayImpl(timeoutSeconds);
         }
+        // Log the page reload event
+        if (!this.isVisible()) {
+            // FIXME (CallStats - issue) this event will not make it to
+            // the CallStats, because the log queue is not flushed, before
+            // "fabric terminated" is sent to the backed
+            APP.conference.logEvent('page.reload');
+        }
         overlay.show();
     }
 };