Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix NPE when a conference request has no payload #1126

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

bgrozev
Copy link
Member

@bgrozev bgrozev commented Jan 18, 2024

Jetty doesn't recognize that the kotlin param can't be null which
results in a NPE and response 500. Return 400 without polluting the logs
instead.

Jetty doesn't recognize that the kotlin param can't be null which
results in a NPE and response 500. Return 400 without polluting the logs
instead.
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (660d705) 27.64% compared to head (0682a6c) 28.93%.
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1126      +/-   ##
============================================
+ Coverage     27.64%   28.93%   +1.29%     
- Complexity      468      475       +7     
============================================
  Files           128      128              
  Lines          7800     7818      +18     
  Branches       1066     1069       +3     
============================================
+ Hits           2156     2262     +106     
+ Misses         5373     5284      -89     
- Partials        271      272       +1     
Files Coverage Δ
.../main/kotlin/org/jitsi/jicofo/xmpp/muc/ChatRoom.kt 0.00% <ø> (ø)
...ofo/src/main/kotlin/org/jitsi/jicofo/xmpp/Smack.kt 100.00% <100.00%> (+100.00%) ⬆️
.../kotlin/org/jitsi/jicofo/rest/ConferenceRequest.kt 0.00% <0.00%> (ø)
...tsi/jicofo/conference/JitsiMeetConferenceImpl.java 44.40% <0.00%> (+1.09%) ⬆️
...n/kotlin/org/jitsi/jicofo/xmpp/muc/ChatRoomImpl.kt 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed9df12...0682a6c. Read the comment docs.

@bgrozev bgrozev merged commit b33632d into jitsi:master Jan 19, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants