Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add grafana dashboards #96

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

genofire
Copy link
Contributor

No description provided.

@spijet
Copy link
Collaborator

spijet commented Dec 16, 2023

Hello @genofire!

Maybe it'd be better to add the dashboard config under the jvb.metrics section of values.yaml? Something like this:

#<...>
jvb:
  #<...>
  metrics:
    grafanaDashboards:
      # Will add Grafana dashboard template
      enabled: false
      labels:
        grafana_dashboard: "1"
      annotations: {}

@genofire
Copy link
Contributor Author

genofire commented Jan 2, 2024

@spijet done

@spijet spijet merged commit 13c48c0 into jitsi-contrib:main Jan 24, 2024
@spijet
Copy link
Collaborator

spijet commented Jan 24, 2024

Merged. Thank you for your time! 💚

@genofire genofire deleted the fix/grafan_dashboards branch January 24, 2024 11:19
@genofire
Copy link
Contributor Author

Thanks for merging, when does it get released?

@spijet
Copy link
Collaborator

spijet commented Jan 24, 2024

I'm planning to package a release after #92 is merged, so we'll have Jigasi, new config/secret options and dashboards all in one nice package. :)

@spijet
Copy link
Collaborator

spijet commented Jan 25, 2024

OK, so I just merged #92. Give me some time to add some finishing touches to the chart and I'll release it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants