Fix autosnapshot when the last slot in an epoch doesn't contain a block #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esemeniuc
reviewed
Nov 19, 2022
| @@ -122,8 +122,8 @@ create_snapshot_for_slot() { | |||
| # for some reason solana-ledger-tool error doesn't cause this script to exit out, so check status here | |||
| exit_status=$? | |||
| if [ $exit_status -ne 0 ]; then | |||
| echo "solana-ledger-tool returned $exit_status" | |||
| exit $exit_status | |||
| echo "solana-ledger-tool returned $exit_status" | |||
There was a problem hiding this comment.
does this check not get executed due to set -eux on line 9?
There was a problem hiding this comment.
eg
#!/bin/bash
set -exu
function foo {
rm aldskjdjkldlkjadskjldkjlskjlkjdlslkjda
echo $?
}
foo
echo 'finished'
There was a problem hiding this comment.
➜ ~ bash demo.sh
+ foo
+ rm aldskjdjkldlkjadskjldkjlskjlkjdlslkjda
rm: cannot remove 'aldskjdjkldlkjadskjldkjlskjlkjdlslkjda': No such file or directory
➜ ~ echo $?
1
the echo finished never runs
There was a problem hiding this comment.
yeah im not totally sure why it doesn't work, there's a comment above it.
segfaultdoc
previously approved these changes
Nov 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: