Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with Ruby 2.5? #1

Closed
obilodeau opened this issue Jan 31, 2018 · 3 comments
Closed

Problem with Ruby 2.5? #1

obilodeau opened this issue Jan 31, 2018 · 3 comments
Labels
bug

Comments

@obilodeau
Copy link
Contributor

See https://travis-ci.org/asciidoctor/asciidoctor-reveal.js/jobs/335441645
@jirutka
Copy link
Owner

jirutka commented Jan 31, 2018

This is problem in ruby-beautify; it’s already reported in erniebrodeur/ruby-beautify#45. Meanwhile you can disable pretty-formatting by setting pretty: false.

@jirutka jirutka added the bug label Jan 31, 2018
obilodeau added a commit to asciidoctor/asciidoctor-reveal.js that referenced this issue Jan 31, 2018
@obilodeau
Using the template compiler in fast mode to fix issues with Ruby 2.5
884e07e 
See jirutka/asciidoctor-templates-compiler#1
and discussion in #179
@obilodeau
Copy link
Contributor Author

The suggested workaround seems to work! Thanks!

@jirutka
Copy link
Owner

jirutka commented Jun 19, 2018

Author of ruby-beautify is not responding to PRs nor email, so I've eventually forked this gem as ruby-beautify2. The latest version of asciidoctor-templates-compiler (0.4.0) depends on the fork, so this issue is fixed now.

@jirutka jirutka closed this as completed Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@obilodeau @jirutka