Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documentの生成に失敗してる #9

Closed
jiro4989 opened this issue Jan 31, 2021 · 2 comments · Fixed by #10
Closed

documentの生成に失敗してる #9

jiro4989 opened this issue Jan 31, 2021 · 2 comments · Fixed by #10
Labels
bug Something isn't working

Comments

@jiro4989
Copy link
Owner

jiro4989 commented Jan 31, 2021 •
edited
Loading

newPBMのrunnableExampleで最大輝度の255を渡すように修正された結果ドキュメント生成が失敗してるっぽい。

PBMは0,1の2値しか受け取らないので上限が指定できないけれど、PGM, PNMで上限を指定できるようになったときに、同様の修正をPBMのrunnableExamplesに当てた結果ドキュメント生成がコケるようになった。

runnableExampleのテストも必要だな
@jiro4989 jiro4989 added the bug Something isn't working label Jan 31, 2021
@jiro4989 jiro4989 mentioned this issue Jan 31, 2021
Merged
@jiro4989
Copy link
Owner Author

思いの外いろんなテストが失敗してた。runnableExamplesのテスト入れてなかったのは失敗だったな

@jiro4989
Copy link
Owner Author

他のライブラリ系のリポジトリもrunnableExamplesのテスト入れるようにしよう

jiro4989 added a commit that referenced this issue Jan 31, 2021
@jiro4989
fix: broken runnableExamples #9 (#10)
96a0471 
* add docs test

* fix

* fix

* fix

* fix

* fix

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: broken runnableExamples #9 jiro4989/pnm
1 participant
@jiro4989