Skip to content

Commit

Permalink
Fixes skupperproject#561 - Respond to HTTP close event in HTTP handle…
Browse files Browse the repository at this point in the history
…r; the websocket close event is never delivered here
  • Loading branch information
jiridanek committed Jun 10, 2022
1 parent f1cffc2 commit 85c0842
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
4 changes: 2 additions & 2 deletions src/http-libwebsockets.c
Original file line number Diff line number Diff line change
Expand Up @@ -742,7 +742,7 @@ static int callback_metrics(struct lws *wsi, enum lws_callback_reasons reason,
return 0;
}

case LWS_CALLBACK_CLOSED: {
case LWS_CALLBACK_CLOSED_HTTP: {
stats->context->wsi_deleted = true;
if (stats->context->callback_completed) {
free(stats->context);
Expand Down Expand Up @@ -800,7 +800,7 @@ static int callback_healthz(struct lws *wsi, enum lws_callback_reasons reason,
else return 0;
}

case LWS_CALLBACK_CLOSED: {
case LWS_CALLBACK_CLOSED_HTTP: {
stats->context->wsi_deleted = true;
if (stats->context->callback_completed) {
free(stats->context);
Expand Down
4 changes: 0 additions & 4 deletions tests/lsan.supp
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@
# found by AddressSanitizer (ASAN)
#

# to be triaged; system_tests_http
leak:^callback_healthz$
leak:^callback_metrics$

# to be triaged; system_tests_http1_adaptor
leak:^pn_condition$
leak:^pn_raw_connection$
Expand Down

0 comments on commit 85c0842

Please sign in to comment.