New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quadric memcpy on toJson #259

Merged

rmorozov merged 2 commits into jinja2cpp:master from ydot13:master

Sep 15, 2024

Contributor

ydot13 commented Sep 12, 2024

accumulate cpy full string on each char, I replaced it with std::string::push_back/append, now its complexity is amortized linear


          fix quadratic speed

ydot13 changed the title ~~Fix quadric memcpy and allocation on toJson~~ Fix quadric memcpy on toJson

Contributor Author

ydot13 commented Sep 12, 2024

@rmorozov please, have a look.

robot-piglet pushed a commit to yandex/yatool that referenced this pull request


          fix jinja2cpp quadric memcpy on json filter

ba02f34

В ожидании влития в апстрим (<jinja2cpp/Jinja2Cpp#259>)  сделал временно патч

В нейро у нас 25% перфа на это уходит: [https://perforator.yandex-team.ru/task/f8beca28-5166-4116-b4db-85f974f785cf?flamegraphReverse=false&frameDepth=46&framePos=117](https://perforator.yandex-team.ru/task/f8beca28-5166-4116-b4db-85f974f785cf?flamegraphReverse=false&frameDepth=3&framePos=0&flamegraphQuery=Serialize%253A%253AFilter)
commit_hash:9ff11e0e7ebc8dace41508f43656ce646f615081


          add reserve

9188f41

Member

rmorozov commented Sep 15, 2024

@ydot13 , seems ok

in c++20 std::accumulate defaults to std::move for init so complexity will definitely be not as bad

but let it be in your way

rmorozov merged commit e98b3b5 into jinja2cpp:master

99 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet