Uid2 decouple cstg #2
Conversation
modules/uid2Cstg.js
Outdated
| @@ -0,0 +1,490 @@ | |||
| /* eslint-disable no-console */ | |||
There was a problem hiding this comment.
Don't think we need this, can't see any uses of console in this file
modules/uid2IdSystem.js
Outdated
| }; | ||
|
|
||
| export function attachTokenGenerator(tokenGeneratorModule) { |
There was a problem hiding this comment.
Does a publisher who wishes to use CSTG need to call this, or is it just for tests?
There was a problem hiding this comment.
No, the publisher don't need to call this, this is for async submodule loading. no matter which module loads first, prebid core will call this function and pass the uid2Cstg in here.
https://github.com/prebid/Prebid.js/blob/master/src/hook.js#L36C8-L49
package.json
Outdated
| @@ -131,6 +131,7 @@ | |||
| "dset": "3.1.2", | |||
| "express": "^4.15.4", | |||
| "fun-hooks": "^0.9.9", | |||
| "gulp-cli": "^2.3.0", | |||
There was a problem hiding this comment.
good catch, I will remove it
gulpfile.js
Outdated
| @@ -450,7 +451,13 @@ gulp.task('build-bundle-verbose', gulp.series(makeWebpackPkg({ | |||
| // public tasks (dependencies are needed for each task since they can be ran on their own) | |||
| gulp.task('test-only', test); | |||
| gulp.task('test-all-features-disabled', testTaskMaker({disableFeatures: require('./features.json'), oneBrowser: 'chrome', watch: false})); | |||
| // gulp.task('test-watch', testTaskMaker({watch: true, file: ['test/spec/modules/uid2idsystem_spec.js']})); | |||
There was a problem hiding this comment.
Do we want to keep the commented-out lines?
There was a problem hiding this comment.
It looks like this example isn't specific to UID2, can we make such a big change?
There was a problem hiding this comment.
No, this PR is against my original PR and not pushed to Prebid repo, those changes are easy for everyone to pull this branch and run tests to see the coverage and tests. I will revert this back when I merge back to uid2-cstg-integration
karma.conf.maker.js
Outdated
There was a problem hiding this comment.
Do we want to keep the commented-out lines?
There was a problem hiding this comment.
Same as above, with this commented-out when you spin up gulp serve-fast you will only see uid2 in the uid2_example page. Those will be removed once we merge back to uid2-cstg-integration
modules/uid2IdSystem.js
Outdated
| } | ||
|
|
||
| const mappedConfig = { | ||
| let mappedConfig = { |
| if (!storedTokenFromSameIdentity(storedTokens, identity)) { | ||
| _logInfo('CSTG supplied new identity - ignoring stored value.', storedTokens.originalIdentity, cstgIdentity); | ||
| // Stored token wasn't originally sourced from the provided identity - ignore the stored value. A new user has logged in? | ||
| if (FEATURES.UID2_CSTG && isCstgEnabled) { |
There was a problem hiding this comment.
Do we need to check FEATURES.UID2_CSTG here?
| @@ -670,13 +752,9 @@ export function Uid2GetId(config, prebidStorageManager, _logInfo, _logWarn) { | |||
| originalToken: suppliedToken ?? storedTokens?.originalToken, | |||
| latestToken: newestAvailableToken, | |||
| }; | |||
| if (cstgIdentity) tokens.originalIdentity = storedTokens?.originalIdentity | |||
| if (FEATURES.UID2_CSTG && isCstgEnabled) { | |||
There was a problem hiding this comment.
Do we need to check FEATURES.UID2_CSTG here?
There was a problem hiding this comment.
we could remove it, with FEATURES.UID2_CSTG line 709-726 will be removed from build, just reduce some bytes
* Flipp Bid Adapter: initial release * Added flippBidAdapter * OFF-372 Support DTX/Hero in flippBidAdapter (#2) * support creativeType * OFF-422 flippBidAdapter handle AdTypes --------- Co-authored-by: Jairo Panduro <[email protected]> * OFF-465 Add getUserKey logic to prebid.js adapter (prebid#3) * Support cookie sync and uid * address pr feedback * remove redundant check * OFF-500 Support "startCompact" param for Prebid.JS prebid#4 * set startCompact default value (prebid#5) * fix docs * use client bidding endpoint * update unit testing endpoint --------- Co-authored-by: Jairo Panduro <[email protected]>
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information