Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: unblock grpcio version #6198

Merged
merged 11 commits into from
Nov 8, 2024
Merged

ci: unblock grpcio version #6198

merged 11 commits into from
Nov 8, 2024

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Sep 15, 2024

Goals:

  • resolves #ISSUE-NUMBER

  • ...

  • ...

  • ...

  • ...

  • check and update documentation. See guide and ask the team.

@github-actions github-actions bot added size/XS area/setup This issue/PR affects setting up Jina labels Sep 15, 2024
@abeppu
Copy link

abeppu commented Nov 5, 2024

Hey there,
Sorry to reach out without context, but I'm wondering if there's any likelihood of these updates to dependencies being merged in the near term?
I was working on using vectordb in an existing, mature codebase. The fact that jina has explicit upper-bounds on the versions of these libraries, and that those upper bounds are rather old (and older than the lower bounds of some other dependencies in our codebase), makes it actually rather messy and challenging for us to use these libraries. Basically, any component that already has a dependency on a newer version of grpcio, opentelemetry-sdk or indeed pydantic or uvicorn cannot cleanly add jina (or vectordb) to its environment or built artifacts.

@JoanFM
Copy link
Member Author

JoanFM commented Nov 5, 2024

I will try to get some time to look into it. If u can check what needs to be done to pass these failing tests, it would be of great help

@github-actions github-actions bot added size/S area/testing This issue/PR affects testing labels Nov 5, 2024
@github-actions github-actions bot added the size/M label Nov 5, 2024
@JoanFM JoanFM force-pushed the check-grpcio branch 2 times, most recently from 86feadb to e85c033 Compare November 6, 2024 08:55
@JoanFM JoanFM force-pushed the check-grpcio branch 2 times, most recently from ea363cf to 49b4e8e Compare November 6, 2024 15:05
@github-actions github-actions bot added the area/docker This issue/PR affects the docker functionality label Nov 7, 2024
@JoanFM JoanFM marked this pull request as ready for review November 8, 2024 09:44
@JoanFM JoanFM requested a review from hanxiao as a code owner November 8, 2024 09:44
@JoanFM JoanFM requested a review from nan-wang as a code owner November 8, 2024 09:44
@JoanFM JoanFM changed the title ci: check grpcio ci: unblock grpcio version Nov 8, 2024
@JoanFM JoanFM force-pushed the check-grpcio branch 3 times, most recently from 0961064 to 7c5f54a Compare November 8, 2024 10:54
@JoanFM JoanFM merged commit 7f3ad55 into master Nov 8, 2024
129 checks passed
@JoanFM JoanFM deleted the check-grpcio branch November 8, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docker This issue/PR affects the docker functionality area/setup This issue/PR affects setting up Jina area/testing This issue/PR affects testing size/L size/M size/S size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants