Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fail to import on armv8 #2506

Merged
merged 20 commits into from
May 29, 2021
Merged

fix: fail to import on armv8 #2506

merged 20 commits into from
May 29, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented May 29, 2021

It's a strange bug caused import grpc, yet i'm not sure it is really the upstream problem.

As mentioned in #2447 , running jina -v on armv8 throws the exception immediately:

free(): invalid pointer
Aborted

After some inspections, I found the cause is import grpc. To reproduce, (only on armv8),

  • adding import grpc before these lines of jina/__init__.py
from jina.types.document import Document
from jina.types.arrays.document import DocumentArray

passes.

  • adding import grpc after these lines of jina/__init__.py
from jina.types.document import Document
from jina.types.arrays.document import DocumentArray

fails.

Unfortunately, I don't have time to dig in on this, but this PR at least figured out this issue and fix #2447

@hanxiao hanxiao requested a review from a team as a code owner May 29, 2021 05:39
@github-actions
Copy link

This PR closes: #2447

@jina-bot jina-bot added size/S area/cicd This issue/PR affects the cicd pipeline area/core This issue/PR affects the core codebase area/docker This issue/PR affects the docker functionality area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality area/housekeeping This issue/PR is housekeeping component/client component/executor component/type executor/meta labels May 29, 2021
@codecov
Copy link

codecov bot commented May 29, 2021

Codecov Report

Merging #2506 (b1d1526) into master (cbd4787) will decrease coverage by 10.76%.
The diff coverage is 100.00%.

❗ Current head b1d1526 differs from pull request most recent head 3d07777. Consider uploading reports for the commit 3d07777 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2506       +/-   ##
===========================================
- Coverage   83.41%   72.65%   -10.77%     
===========================================
  Files         152      152               
  Lines        9447     9445        -2     
===========================================
- Hits         7880     6862     -1018     
- Misses       1567     2583     +1016     
Flag Coverage Δ
daemon 82.97% <ø> (+35.99%) ⬆️
jina 71.94% <100.00%> (-11.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/helloworld/fashion/app.py 83.33% <ø> (-1.29%) ⬇️
jina/__init__.py 69.69% <100.00%> (ø)
jina/clients/request/helper.py 84.48% <100.00%> (ø)
jina/executors/decorators.py 88.33% <100.00%> (-5.00%) ⬇️
jina/types/arrays/document.py 83.61% <100.00%> (ø)
jina/types/document/generators.py 92.00% <100.00%> (ø)
jina/schemas/pod.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/ping.py 0.00% <0.00%> (-100.00%) ⬇️
jina/schemas/flow.py 0.00% <0.00%> (-100.00%) ⬇️
jina/schemas/meta.py 0.00% <0.00%> (-100.00%) ⬇️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a11c3ed...3d07777. Read the comment docs.

@hanxiao hanxiao merged commit da68531 into master May 29, 2021
@hanxiao hanxiao deleted the fix-2447 branch May 29, 2021 08:09
@alexcg1
Copy link
Member

alexcg1 commented May 31, 2021

I'll check if this works on RaspPi Zero now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd This issue/PR affects the cicd pipeline area/core This issue/PR affects the core codebase area/docker This issue/PR affects the docker functionality area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality area/housekeeping This issue/PR is housekeeping component/client component/executor component/type executor/meta size/S
Projects
None yet
3 participants