-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fail to import on armv8 #2506
Conversation
This PR closes: #2447 |
Codecov Report
@@ Coverage Diff @@
## master #2506 +/- ##
===========================================
- Coverage 83.41% 72.65% -10.77%
===========================================
Files 152 152
Lines 9447 9445 -2
===========================================
- Hits 7880 6862 -1018
- Misses 1567 2583 +1016
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I'll check if this works on RaspPi Zero now |
It's a strange bug caused
import grpc
, yet i'm not sure it is really the upstream problem.As mentioned in #2447 , running
jina -v
on armv8 throws the exception immediately:After some inspections, I found the cause is
import grpc
. To reproduce, (only on armv8),import grpc
before these lines ofjina/__init__.py
passes.
import grpc
after these lines ofjina/__init__.py
fails.
Unfortunately, I don't have time to dig in on this, but this PR at least figured out this issue and fix #2447