Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jimp.d.ts): fix getBase64 and getBase64Async function arguments #1094

Merged
merged 1 commit into from
Feb 4, 2023

Conversation

pkjy
Copy link
Contributor

@pkjy pkjy commented Aug 1, 2022

fix(jimp.d.ts): fix getBase64 and getBase64Async function arguments types

add type AUTO since getBase64 and getBase64Async support Jimp.AUTO.

fix #878

What's Changing and Why

What else might be affected

Tasks

  • Add tests
  • Update Documentation
  • Update jimp.d.ts
  • Add SemVer Label
📦 Published PR as canary version: 0.16.2-canary.1094.1345.0

✨ Test out this PR locally via:

npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install [email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
# or 
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add [email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]

add type AUTO since getBase64 and getBase64Async support Jimp.AUTO.

fix #878
@hipstersmoothie hipstersmoothie merged commit de16626 into jimp-dev:master Feb 4, 2023
@hipstersmoothie
Copy link
Collaborator

🚀 PR was released in v0.17.7 🚀

@hipstersmoothie hipstersmoothie added the released This issue/pull request has been released. label Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript: Compile error when using getBufferAsync(Jimp.AUTO)
2 participants