This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey !
This PR is to fix cases where ids are set and start with a number (this is valid HTML5).
querySelector
raise aSyntaxError
as it expects a valid CSS selector, yet we can usegetElementById
as we are only looking for idsI changed the test fixtures to have
3rd-heanding
as id and fixed the selector insrc/util/updateActiveNavItem.js
andsrc/util/updatePositionData.js
My demo Pen works as expected : https://codepen.io/acekat/pen/pooxLjy
Thanks for your work 👍