pathikrit#77 - copyTo with overwrite should not delete all of origina…

…l files in target folder.
jiminhsieh · Jul 14, 2017 · b24cab5 · b24cab5
1 parent cf2d718
commit b24cab5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/core/src/main/scala/better/files/File.scala b/core/src/main/scala/better/files/File.scala
@@ -690,7 +690,6 @@ class File private(val path: Path)(implicit val fileSystem: FileSystem = path.ge
     */
   def copyTo(destination: File, overwrite: Boolean = false)(implicit copyOptions: File.CopyOptions = File.CopyOptions(overwrite)): destination.type = {
     if (isDirectory) {//TODO: maxDepth?
-      if (overwrite) destination.delete(swallowIOExceptions = true)
       Files.walkFileTree(path, new SimpleFileVisitor[Path] {
         def newPath(subPath: Path): Path = destination.path.resolve(path.relativize(subPath))
 

diff --git a/core/src/test/scala/better/files/FileSpec.scala b/core/src/test/scala/better/files/FileSpec.scala
@@ -388,8 +388,10 @@ class FileSpec extends CommonSpec {
 
   it should "copy" in {
     (fb / "t3" / "t4.txt").createIfNotExists(createParents = true).writeText("Hello World")
+    (fb / "t5" / "t5.txt").createIfNotExists(createParents = true).writeText("Scala Awesome")
     cp(fb / "t3", fb / "t5")
     (fb / "t5" / "t4.txt").contentAsString shouldEqual "Hello World"
+    (fb / "t5" / "t5.txt").contentAsString shouldEqual "Scala Awesome"
     (fb / "t3").exists shouldBe true
   }