don't make_shared inline

jikunshang · Jul 2, 2019 · 9f59160 · 9f59160
1 parent 484b3a2
commit 9f59160
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/cpp/src/arrow/python/common.cc b/cpp/src/arrow/python/common.cc
@@ -81,8 +81,8 @@ Status PyBuffer::Init(PyObject* obj) {
     }
     return Status::OK();
   } else {
-    return Status(StatusCode::Invalid, "Couldn't convert to buffer.",
-                  std::make_shared<PythonErrorDetail>());
+    auto detail = std::make_shared<PythonErrorDetail>();
+    return Status(StatusCode::Invalid, "Couldn't convert to buffer.", detail);
   }
 }
 
@@ -149,8 +149,8 @@ Status PassPyError() {
   if (PyErr_Occurred()) {
     // Do not call PyErr_Clear, the assumption is that someone further
     // up the call stack will want to deal with the Python error.
-    return Status(StatusCode::UnknownError, "Python Error",
-                  std::make_shared<PythonErrorDetail>());
+    auto detail = std::make_shared<PythonErrorDetail>();
+    return Status(StatusCode::UnknownError, "Python Error", detail);
   }
   return Status::OK();
 }