Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

append history items to history file #1

Merged
merged 1 commit into from
Jul 30, 2021
Merged

append history items to history file #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ type commonState struct {
outputRedirected bool
inputRedirected bool
history []string
newlyAddedHistory []string
historyMutex sync.RWMutex
completer WordCompleter
columns int
Expand Down Expand Up @@ -118,7 +119,7 @@ func (s *State) WriteHistory(w io.Writer) (num int, err error) {
s.historyMutex.RLock()
defer s.historyMutex.RUnlock()

for _, item := range s.history {
for _, item := range s.newlyAddedHistory {
_, err := fmt.Fprintln(w, item)
if err != nil {
return num, err
Expand All @@ -140,6 +141,7 @@ func (s *State) AppendHistory(item string) {
}
}
s.history = append(s.history, item)
s.newlyAddedHistory = append(s.newlyAddedHistory, item)
if len(s.history) > HistoryLimit {
s.history = s.history[1:]
}
Expand Down