Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests for Java 17+ #112

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix tests for Java 17+ #112

wants to merge 1 commit into from

Conversation

nyg
Copy link
Contributor

@nyg nyg commented Feb 2, 2024

Hello,

I have not able to run mvn clean install with Java 21. The issue was due to unit tests failing. I fixed it by:

  1. updating jmock, Java 11 support was added in 2.10.0,
  2. removing jmock-legacy which used cglib by jmock-imposters which uses byte-buddy,
  3. specify latest version of byte-buddy for Java 11+ support.

So now jmxterm can be built using Java 21, but running it still fails when listing JVM (due to other issues).

Best,
nyg

@nyg nyg changed the title Fix build for Java 21 Fix tests for Java 17+ Feb 3, 2024
@nyg nyg mentioned this pull request Feb 4, 2024
Open
@nyg
Copy link
Contributor Author

nyg commented Mar 5, 2024

Hello @jiaqi,

Did you have some time to review my PRs? Please let me know if there's anything I can improve or change.

Thanks a lot!

Best,
nyg

@nyg
Copy link
Contributor Author

nyg commented Apr 3, 2024

Hello @jiaqi, thanks for approving! Could you merge too?

@nyg nyg mentioned this pull request Apr 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiaqi jiaqi jiaqi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nyg @jiaqi