Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a java module version of jsoup-xxx.jar #1943

Closed
hbsoftdj opened this issue Apr 20, 2023 · 3 comments · Fixed by #2025
Closed

Create a java module version of jsoup-xxx.jar #1943

hbsoftdj opened this issue Apr 20, 2023 · 3 comments · Fixed by #2025
Assignees
@jhy
Labels
fixed improvement
Milestone
1.17.1

Comments

@hbsoftdj
Copy link

I am using jsoup in a javafx desktop app project and jsoup is working beautifully (thank you). However, the jsoup-xxx.jar file is not a java module. It is taken as an automatic module while building the project with module-info.java and everything works fine. It breaks when I try to create a runtime image with jlink. I suspect it is because jsoup jar is not a java module. Is it possible to make the library available as a java module?
@jhy jhy added the discussion Discussion for a new feature, or other change proposal label Apr 24, 2023
@jhy jhy changed the title label:discussion Create a java module version of jsoup-xxx.jar Create a java module version of jsoup-xxx.jar Apr 24, 2023
@jhy jhy added improvement and removed discussion Discussion for a new feature, or other change proposal labels Apr 25, 2023
@jhy
Copy link
Owner

jhy commented Apr 25, 2023

Yes, I think it does make sense to make it a module now. Some initial work was done but not completed, in particular as I didn't see a specific benefit vs an automatic module. But if tools are being picky about it being an explicitly defined module, I guess it makes sense.

@cowwoc
Copy link

cowwoc commented Oct 25, 2023

@jhy Maven and jlink complain unless module-info.class is present. Please provide to a full-fledged module.

jhy added a commit that referenced this issue Nov 1, 2023
@jhy
Repackaged the library with native (vs automatic) JPMS module support
882bb9c 
Fixes #1943
Fixes #1466
@jhy jhy mentioned this issue Nov 1, 2023
Merged
@jhy jhy closed this as completed in #2025 Nov 1, 2023
jhy added a commit that referenced this issue Nov 1, 2023
@jhy
Repackaged the library with native (vs automatic) JPMS module support (…
a8564c3 
…#2025)

Repackaged the library with native (vs automatic) JPMS module support

Fixes #1943
Fixes #1466

Min builder is JDK 9

#2026 tracks adding a test action (not compile) for JDK 8.
@jhy jhy self-assigned this Nov 1, 2023
@jhy jhy added this to the 1.17.1 milestone Nov 1, 2023
@jhy
Copy link
Owner

jhy commented Nov 1, 2023 •
edited
Loading

Thanks all - I have implemented this in #2025.

It would be great if folks could test this out and report back with confirmation of success or any issues. Please report back on the PR #2025 (or a new issue if any problems) as there are a few duplicate issues for this. To use a snapshot, git pull && mvn install, and use version 1.17.1-SNAPSHOT in your project.

@jhy jhy added the fixed label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhy jhy

Labels
fixed improvement
Projects
None yet
Milestone
1.17.1
Development

Successfully merging a pull request may close this issue.

Repackaged the library with native (vs automatic) JPMS module support jhy/jsoup
3 participants
@jhy @cowwoc @hbsoftdj