Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refractor/UI #1123

Merged
merged 11 commits into from
Oct 14, 2024
Merged

Refractor/UI #1123

merged 11 commits into from
Oct 14, 2024

Conversation

zydtiger
Copy link

Description

Refractor side scroller for course evaluations to ts and changes some files in constants.

@JiaqiWang18 JiaqiWang18 self-requested a review May 16, 2024 23:43
Copy link
Member

@JiaqiWang18 JiaqiWang18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI Failed due to TS lint errors, these needs to be fixed first

@zydtiger
Copy link
Author

zydtiger commented Jun 23, 2024

@JiaqiWang18 I believe on my side it only shows CI failed? It says TSLint passed after I committed a fix.

Copy link
Collaborator

@spencerckhuang spencerckhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@spencerckhuang spencerckhuang merged commit 5406643 into jhuopensource:develop Oct 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants