Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Adds dark mode image for master slot empty state #1111

Merged
merged 8 commits into from
Apr 7, 2024

Conversation

zydtiger
Copy link

@zydtiger zydtiger commented Apr 6, 2024

Description

Adds a dark mode image for when the master course slot is empty. Makes it more coherent with dark mode UI.

Change Log

Before

image

After

image

@zydtiger
Copy link
Author

zydtiger commented Apr 6, 2024

I think my vscode formatter reformatted the file. The only line I changed was this:
image

Copy link
Member

@JiaqiWang18 JiaqiWang18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter CI failed, could you check the format of SideBar.tsx

@JiaqiWang18
Copy link
Member

I think my vscode formatter reformatted the file. The only line I changed was this: image

That's fine because we want the format to be consistent with rest of the codebase but TSLint checks failed so there are more format issues that need to be fixed

@JiaqiWang18 JiaqiWang18 self-requested a review April 7, 2024 21:21
@JiaqiWang18 JiaqiWang18 merged commit af23360 into jhuopensource:develop Apr 7, 2024
2 of 3 checks passed
@zydtiger zydtiger deleted the fix/side-bar-dark-ui branch April 7, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants