Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluations: Add endpoint and update display of evaluations #1057

Merged
merged 5 commits into from
Dec 9, 2023

Conversation

jchen324
Copy link

@jchen324 jchen324 commented Dec 2, 2023

Description

  • I add a new endpoint in courses for fetching all courses in JSON format
  • The big evaluation box with summary is rendered conditionally dependent on whether the summary string is empty
  • Because the big evaluation boxes are rendered conditionally, all small evaluation boxes now display instructors' names
    Screen Recording 2023-12-02 at 12 52 24 PM (2)

@jchen324 jchen324 added the feature-request For new feature request label Dec 2, 2023
@jchen324 jchen324 requested a review from JiaqiWang18 December 2, 2023 17:59
@jchen324 jchen324 self-assigned this Dec 2, 2023
@jchen324 jchen324 marked this pull request as draft December 2, 2023 18:26
@jchen324 jchen324 force-pushed the feature/evaluations branch from 5423f86 to 77d9d57 Compare December 2, 2023 19:24
@jchen324 jchen324 marked this pull request as ready for review December 9, 2023 19:57
@JiaqiWang18 JiaqiWang18 merged commit 05ebbe6 into jhuopensource:develop Dec 9, 2023
3 checks passed
@jchen324 jchen324 deleted the feature/evaluations branch December 21, 2023 07:08
@jchen324 jchen324 linked an issue Dec 21, 2023 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request For new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update course evals
2 participants