Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/keyboard shortcuts #1052

Merged
merged 11 commits into from
Dec 1, 2023
Merged

Feature/keyboard shortcuts #1052

merged 11 commits into from
Dec 1, 2023

Conversation

spencerckhuang
Copy link
Collaborator

Description

Added keyboard shortcuts to CourseModalBody:

  • Use left/right arrow keys to navigate between sections
  • Use enter key to add a hovered section to timetable
  • Use escape key to exit out of course modal

@spencerckhuang
keyboard-shortcuts: registered key-presses in CourseModalBody.txt and…
2d58833 
… printed to console
@spencerckhuang
keyboard-shortcuts: created currentHoveredSection state to represente…
5cc8fdd 
… hovered section index and manipulated it using left/right arrow keys
@spencerckhuang
keyboard-shortcuts: added basic kb functionality to coursemodal (left…
1c1397e 
…, right keys to shift between sections)
@spencerckhuang
keyboardshortcuts: fixed bug where app crashes upon closing course mo…
e0ff207 
…dal (moved hooks to top of component)
@spencerckhuang
keyboardshortcuts: fixed bug in handlekeypress that now allows users …
ae8e8b5 
…to hit 'enter' after hovering over a course to pick it
@spencerckhuang
keyboardshortcuts: added escape key shortcut to exit coursemodal
92429c2
@spencerckhuang
keyboardshortcuts: changed background color of coursemodalsection upo…
e38b0ec 
…n hover using arrow keys
@spencerckhuang
keyboardshortcuts: removed unnecessary console.logs and comments
15fad5d
@spencerckhuang
keyboardshortcuts: ran prettier
cea8458
@spencerckhuang
keyboardshortcuts: removed erroneous import statement from CourseModa…
ec1f178 
…lBody.tsx
@spencerckhuang
keyboardshortcuts: attempting to fix BE tests by adding pause after r…
77d0829 
…emoving course from modal
JiaqiWang18
JiaqiWang18 approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@JiaqiWang18 JiaqiWang18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@JiaqiWang18 JiaqiWang18 merged commit 02e9d65 into jhuopensource:develop Dec 1, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiaqiWang18 JiaqiWang18 JiaqiWang18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spencerckhuang @JiaqiWang18