Merge pull request #1138 from spencerckhuang/fix/ui-bug-fixes-10-24

Fixed bug that showed invalid areas of focus
jhuopensource · Oct 8, 2024 · e22425b · e22425b
2 parents 48a8608 + c8ada54
commit e22425b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/static/js/redux/ui/SearchResult.tsx b/static/js/redux/ui/SearchResult.tsx
@@ -141,16 +141,24 @@ const SearchResult = (props: SearchResultProps) => {
 };
 
 type AreaBubbleProps = { areas: string[] };
-export const AreaBubble = ({ areas }: AreaBubbleProps) =>
-  areas.length > 0 ? (
+export const AreaBubble = ({ areas }: AreaBubbleProps) => {
+  const isValidArea = (rawAreaSingle: string): boolean => {
+    const validAreas = ["H", "S", "N", "E", "Q", "writing"];
+    return validAreas.includes(rawAreaSingle);
+  };
+
+  const validAreas = areas.filter((areaCandidate) => isValidArea(areaCandidate));
+
+  return validAreas.length > 0 ? (
     <div className="areas">
-      {areas.map((area) => (
+      {validAreas.map((area) => (
         <div className={`bubble ${area}`} key={area}>
           {area}
         </div>
       ))}
     </div>
   ) : null;
+};
 
 type WritingIntensiveProps = { isWritingIntensive: string };
 export const WritingIntensive = ({ isWritingIntensive }: WritingIntensiveProps) =>

diff --git a/tsconfig.json b/tsconfig.json
@@ -10,6 +10,6 @@
     "allowJs": true,
     "moduleResolution": "node",
     "esModuleInterop": true,
-    "lib": ["es2015", "DOM"]
+    "lib": ["DOM", "es2016"]
   }
 }