Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redmine Attachment links take user outside Redmine to Amazon S3 Object URL #3

Open
ptomka opened this issue Apr 14, 2020 · 1 comment

Comments

@ptomka
Copy link

ptomka commented Apr 14, 2020

When clicking on a Redmine attachment link the user is taken to the Amazon S3 Object URL.

Redmine Link

Amazon S3 Object URL

http://<redmine_site_address>/attachments/8

https://<bucket_name>.amazonaws.com/2020/04/

@KerberosMorphy
Copy link

KerberosMorphy commented May 5, 2020

Get the same observation, doesn't feel totally safe with this solution since I have to keep all attachments publics if I want them to be accessible.

EDIT: Found this PR #4 Who add Pre Signed URL, still pointing on external Object URL, but at least there's a private option.

EDIT2: Found a solution, you can show images directly in redmine by adding these line in amazon_s3/lib/amazon_s3/patches/attachments_controller.rb after line 27:

    elsif @attachment.is_image?
      render :action => 'image'

Hunter-Thompson added a commit to Hunter-Thompson/redmine4_amazon_s3 that referenced this issue Dec 27, 2020
apslsistemas pushed a commit to apslsistemas/redmine4_amazon_s3 that referenced this issue Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants