-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: alice_chopper interceptor #185
fix: alice_chopper interceptor #185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Expect I still have the same questions about the alice_token
headers thats added when making the hashcode of the request.
Also I'm still wondering if the hashcode is needed at all.
Yeah, I kept it in because I'm not 100% sure it can be dropped. @jhomlala can probably shed some light on it. |
Just reminding every one ^^ |
I think alice token can be removed - it's deprecated. I'll merge this PR and fix it with another PR. Thanks! Edit: My bad, alice token can't be removed because it's needed for differentiate similiar http calls. I need to leave it as it is. |
This PR supersedes #180
Hey 👋
Recently I stumbled upon this awesome package and I noticed it (also) uses Chopper Interceptors.
In Chopper v8.0.0, there was a significant restructuring of interceptors. The
RequestInterceptor
andResponseInterceptor
classes, as well as their function counterparts, were removed.Since I'm one of the maintainers of Chopper I thought I'd contribute to this library by updating the
AliceChopperInterceptor
to be compatible with Chopper v8.0.0.CC / @Guldem
✅ I tested the provided Alice Chopper example on an Android Simulator.