Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alice_chopper interceptor #185

Merged
merged 3 commits into from
Jun 7, 2024
Merged

fix: alice_chopper interceptor #185

merged 3 commits into from
Jun 7, 2024

Conversation

techouse
Copy link
Collaborator

@techouse techouse commented Jun 5, 2024

This PR supersedes #180


Hey 👋

Recently I stumbled upon this awesome package and I noticed it (also) uses Chopper Interceptors.

In Chopper v8.0.0, there was a significant restructuring of interceptors. The RequestInterceptor and ResponseInterceptor classes, as well as their function counterparts, were removed.

Since I'm one of the maintainers of Chopper I thought I'd contribute to this library by updating the AliceChopperInterceptor to be compatible with Chopper v8.0.0.

CC / @Guldem


✅ I tested the provided Alice Chopper example on an Android Simulator.

@techouse techouse marked this pull request as ready for review June 5, 2024 18:53
@techouse techouse changed the title chore: update alice_chopper interceptor fix: update alice_chopper interceptor Jun 5, 2024
@techouse techouse changed the title fix: update alice_chopper interceptor fix: alice_chopper interceptor Jun 5, 2024
@techouse
Copy link
Collaborator Author

techouse commented Jun 5, 2024

Can you please throw an eye on this once you can @jhomlala 🙏

CC / @Guldem

Copy link

@Guldem Guldem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Expect I still have the same questions about the alice_token headers thats added when making the hashcode of the request.

Also I'm still wondering if the hashcode is needed at all.

@techouse
Copy link
Collaborator Author

techouse commented Jun 6, 2024

Expect I still have the same questions about the alice_token headers thats added when making the hashcode of the request.

Yeah, I kept it in because I'm not 100% sure it can be dropped. @jhomlala can probably shed some light on it.

@Guldem
Copy link

Guldem commented Jun 6, 2024

Expect I still have the same questions about the alice_token headers thats added when making the hashcode of the request.

Yeah, I kept it in because I'm not 100% sure it can be dropped. @jhomlala can probably shed some light on it.

Just reminding every one ^^

@jhomlala
Copy link
Owner

jhomlala commented Jun 7, 2024

I think alice token can be removed - it's deprecated. I'll merge this PR and fix it with another PR. Thanks!

Edit: My bad, alice token can't be removed because it's needed for differentiate similiar http calls. I need to leave it as it is.

@jhomlala jhomlala merged commit c8678d0 into jhomlala:master Jun 7, 2024
@techouse techouse deleted the chore/chopper-v8-interceptor branch June 7, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants