Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reconciled the port for sonar.host to match sonar.yml #328

Merged
merged 6 commits into from
Nov 10, 2021

Conversation

somayaj
Copy link
Contributor

@somayaj somayaj commented Nov 6, 2021

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 6, 2021

CLA assistant check
All committers have signed the CLA.

@pascalgrimaud
Copy link
Member

Thanks for your contribution
But I think the correct fix would be to update the sonar.yml instead, to be consistent with what the generator-jhipster should generate: https://github.com/jhipster/generator-jhipster/blob/main/generators/server/templates/src/main/docker/sonar.yml.ejs

I think it's because this project is not sync with last version of JHipster

@somayaj
Copy link
Contributor Author

somayaj commented Nov 7, 2021

Thanks for your contribution But I think the correct fix would be to update the sonar.yml instead, to be consistent with what the generator-jhipster should generate: https://github.com/jhipster/generator-jhipster/blob/main/generators/server/templates/src/main/docker/sonar.yml.ejs

I think it's because this project is not sync with last version of JHipster

Yes, fixed. please check the latest commit.

src/main/docker/sonar.yml Outdated Show resolved Hide resolved
@somayaj
Copy link
Contributor Author

somayaj commented Nov 9, 2021

@pascalgrimaud when will this be merged?

@pascalgrimaud
Copy link
Member

When the CI passes.
It seems to be an error with prettier. Can you have a look plz?

@pascalgrimaud
Copy link
Member

Thanks for your contribution @somayaj :)

@pascalgrimaud pascalgrimaud merged commit 1b11aff into jhipster:main Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants