Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue: account with authentication JWT #7554

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

abdelfetah18
Copy link
Contributor

@abdelfetah18 abdelfetah18 commented Sep 23, 2023

Fix #897

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b872ce4) 100.00% compared to head (b5fc7d2) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##                main     #7554   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      2616      2623    +7     
===========================================
  Files            677       680    +3     
  Lines          11503     11570   +67     
  Branches         245       245           
===========================================
+ Hits           11503     11570   +67     
Files Coverage Δ
...tech/jhipster/lite/generator/JHLiteModuleSlug.java 100.00% <100.00%> (ø)
...rity/jwt/application/VueJwtApplicationService.java 100.00% <100.00%> (ø)
...t/vue/security/jwt/domain/VueJwtModuleFactory.java 100.00% <100.00%> (ø)
...rastructure/primary/VueJwtModuleConfiguration.java 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DamnClin
Copy link
Collaborator

cc @Gnuk do you have some time to take a look at it?

@Gnuk
Copy link
Collaborator

Gnuk commented Sep 24, 2023

cc @Gnuk do you have some time to take a look at it?

I did a quick review and I have a question:

I'm using most of the time dash - character inside my folder names to not use camelCase like i see here. I know in java it's in lowercase with underscores _ for multiple words. In JS environment i see more kebab-case usage. So maybe it's interesting to use kebab-case for multiple work in a package like name and keep the usage of CamelCase like Java in the FileName itself.

I don't know if in JHipster Lite we have already made a choice about this.

@DamnClin
Copy link
Collaborator

cc @Gnuk do you have some time to take a look at it?

I did a quick review and I have a question:

I'm using most of the time dash - character inside my folder names to not use camelCase like i see here. I know in java it's in lowercase with underscores _ for multiple words. In JS environment i see more kebab-case usage. So maybe it's interesting to use kebab-case for multiple work in a package like name and keep the usage of CamelCase like Java in the FileName itself.

I don't know if in JHipster Lite we have already made a choice about this.

For java packages it's _, - for the others

@abdelfetah18
Copy link
Contributor Author

any update ?

@pascalgrimaud
Copy link
Member

Sorry about this, I'll try to give it a try and have a look at this PR
Thanks for your patience :)

@abdelfetah18
Copy link
Contributor Author

Sorry about this, I'll try to give it a try and have a look at this PR Thanks for your patience :)

No problem, Take your time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue: account with authentication JWT
4 participants