Fix classpath jar workaround for Windows #7391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good Catch. Looks good to me. Thx for the pr. |
|
I can't test but I totally understand your issue and agree on it. Should we do the same with Maven? |
|
I didn't find any traces of similar workaround in maven build, will take a deeper look |
|
Do we need that for maven? I think the boot run tasks work differently. At least we don't have something for maven in place as far as I can remember. |
|
Oh I have no idea. But indeed I think we only had this issue with Gradle. So let's forget about Maven. |
|
I don't know about Maven, I did the original workaround from my Windows days when I encountered it |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classpath is already too long to be handled on windows, so classpath should be replaced with classpath jar (btw, renamed task and jar to better reflect what it does). In current version of jhipster, classpath jar is added to already-too-long-classpath, so workaround doesn't work. Btw, this workaround is not needed on Windows 10, if "Long Paths" feature is enabled (see https://www.howtogeek.com/266621/how-to-make-windows-10-accept-file-paths-over-260-characters/), basically LongPathsEnabled should be "1" under HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\FileSystem registry path.