fix command path in upgrade/index.js for windows users #6167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarziou
reviewed
Jul 24, 2017
generators/upgrade/index.js
Outdated
| @@ -79,7 +79,8 @@ module.exports = UpgradeGenerator.extend({ | |||
| this.log(`Regenerating application with JHipster ${version}...`); | |||
| let generatorCommand = 'yo jhipster'; | |||
| if (semver.gte(version, FIRST_CLI_SUPPORTED_VERSION)) { | |||
| generatorCommand = this.clientPackageManager === 'yarn' ? '$(yarn bin)/jhipster' : '$(npm bin)/jhipster'; | |||
| const generatorDir = this.clientPackageManager === 'yarn' ? shelljs.exec('yarn bin') : shelljs.exec('npm bin'); | |||
There was a problem hiding this comment.
I would turn off console output:
shelljs.exec('yarn bin', {silent: true})There was a problem hiding this comment.
Also according to the doc sync exec should use stdout, though it seems to work without it.
shelljs.exec('yarn bin', {silent: true}).stdout;There was a problem hiding this comment.
Oh yes, forgot to do that, thanks.
|
@gmarziou thanks for review comments. Not sure if you mean you'll change the code by yourself or need my follow-up. Guess you guys are busy so anyway I did the change to save your time. |
ruddell
reviewed
Jul 25, 2017
generators/upgrade/index.js
Outdated
| @@ -79,7 +79,8 @@ module.exports = UpgradeGenerator.extend({ | |||
| this.log(`Regenerating application with JHipster ${version}...`); | |||
| let generatorCommand = 'yo jhipster'; | |||
| if (semver.gte(version, FIRST_CLI_SUPPORTED_VERSION)) { | |||
| generatorCommand = this.clientPackageManager === 'yarn' ? '$(yarn bin)/jhipster' : '$(npm bin)/jhipster'; | |||
| const generatorDir = this.clientPackageManager === 'yarn' ? shelljs.exec('yarn bin', { silent: true }).stdout : shelljs.exec('npm bin', { silent: true }).stdout; | |||
There was a problem hiding this comment.
Please change { silent: true } to { silent: this.silent } so that the --verbose flag will print the result of the command (this is how the rest of the shelljs commands in this file are set up)
This was referenced Jan 5, 2024
This was referenced Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6161