Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More fixes for cypress relationships. #16644

Merged
merged 4 commits into from
Oct 12, 2021

Conversation

mshima
Copy link
Member

@mshima mshima commented Oct 11, 2021

Related to #16617, #16504 and #14103.

Deploy fixes for:

  • Fixes react many-to-one relationships
    Api call were passing flatten relationships values eg:
userId: 1
user: {id: 1}
  • Reactive doesn't allows update operation for entities without fields or relationships.
    Fix: return the original entity without executing the sql operation.

Deploy workarounds for:

  • Reactive + MariaDB doesn't allow null Instant fields (Not applicable to our frontend, it's never null).
    Workaround: never pass null to Instant fields.
  • Reactive + PostgresDB fails to insert/update entities without data.
    Workaround: always pass at least 1 field.

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@DanielFran DanielFran merged commit 371ef97 into jhipster:main Oct 12, 2021
@pascalgrimaud pascalgrimaud added this to the 7.4.0 milestone Oct 14, 2021
@mshima mshima deleted the skip_ci-cypress_entities branch October 26, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants