unflatten criteria class fixes: #13133 #14180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yelhouti
force-pushed
the
unflatten-criteria
branch
2 times, most recently
from
06362dd to
e465b3c
Compare
yelhouti
force-pushed
the
unflatten-criteria
branch
from
e465b3c to
67f2d32
Compare
1 task
Tcharl
reviewed
Aug 10, 2021
| Specification<<%= asEntity('User') %>> specification = Specification.where(null); | ||
| if (criteria != null) { | ||
| if (criteria.getId() != null) { | ||
| specification = specification.and(build<%= (user.primaryKey.type === 'String' || user.primaryKey.type === 'UUID') ? 'String' : 'Range' %>Specification(criteria.getId(), <%= asEntity('User') %>_.id)); |
There was a problem hiding this comment.
Use derived properties ? we're trying to ban equality checks in ejs templates
|
I never used jhipster criteria, who can review this one? |
|
/reopen ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.