Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect user api and create a filtered user api for relationships. #12374

Closed
1 task
mshima opened this issue Sep 4, 2020 · 12 comments
Closed
1 task

Protect user api and create a filtered user api for relationships. #12374

mshima opened this issue Sep 4, 2020 · 12 comments
Labels
area: enhancement 🔧 area: JHipster Code 💻 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: api theme: security $200 https://www.jhipster.tech/bug-bounties/
Milestone

Comments

@mshima
Copy link
Member

mshima commented Sep 4, 2020

Overview of the feature request

I propose to:

  • Move current '/api/users' to '/api/admin/users' and protect it with admin role.
  • Create a compatible '/api/users' with filtered data (id, first and last name).
    And enable by default only if there is some relationship with User.
Motivation for or Use Case

Create a safer default to prevent privacy issues.

Related issues or PR
  • Checking this box is mandatory (this is just to show you read everything)
@pascalgrimaud
Copy link
Member

Big +1

About

Create a compatible '/api/users' with filtered data (id, first and last name).
And enable by default only if there is some relationship with User

do you have an idea how to do this part ?

@pascalgrimaud
Copy link
Member

unless you want to take this ticket @mshima, I'd like to keep this for our JHipster Code in 1 week.
It's not difficult to achieve it.
Are you ok ?

@mshima
Copy link
Member Author

mshima commented Sep 5, 2020

@pascalgrimaud I will not take this ticket.
Most of the job I am doing is related to the workflow.
My own todo is almost finished, then I will create some tickets with cleanup suggestions.
I would suggest to add a bounty to it, but you can keep it to JHipster Code.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.
Our core developers tend to be more verbose on denying. If there is no negative comment, possibly this feature will be accepted.
We are accepting PRs 😃.
Comment or this will be closed in 7 days

@pascalgrimaud
Copy link
Member

important to have

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.
Our core developers tend to be more verbose on denying. If there is no negative comment, possibly this feature will be accepted.
We are accepting PRs 😃.
Comment or this will be closed in 7 days

@pascalgrimaud pascalgrimaud added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $100 https://www.jhipster.tech/bug-bounties/ and removed area: stale labels Nov 10, 2020
@pascalgrimaud
Copy link
Member

adding a bounty, if it can motivated someone

gzsombor added a commit to gzsombor/generator-jhipster that referenced this issue Nov 16, 2020
…nt and PublicUserDTO for public consumptions
gzsombor added a commit to gzsombor/generator-jhipster that referenced this issue Nov 16, 2020
…nt and PublicUserDTO for public consumptions
gzsombor added a commit to gzsombor/generator-jhipster that referenced this issue Nov 16, 2020
…nt and PublicUserDTO for public consumptions
gzsombor added a commit to gzsombor/generator-jhipster that referenced this issue Nov 20, 2020
…nt and PublicUserDTO for public consumptions
gzsombor added a commit to gzsombor/generator-jhipster that referenced this issue Nov 21, 2020
…nt and PublicUserDTO for public consumptions
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.
Our core developers tend to be more verbose on denying. If there is no negative comment, possibly this feature will be accepted.
We are accepting PRs 😃.
Comment or this will be closed in 7 days

@pascalgrimaud
Copy link
Member

PR in progress: #13048

pascalgrimaud added a commit that referenced this issue Dec 18, 2020
@pascalgrimaud pascalgrimaud added $200 https://www.jhipster.tech/bug-bounties/ and removed $100 https://www.jhipster.tech/bug-bounties/ labels Dec 18, 2020
@pascalgrimaud
Copy link
Member

I'm increasing the bounty as it was much work than expected
Don't forget it @gzsombor

@pascalgrimaud pascalgrimaud added this to the 7.0.0-beta.0 milestone Dec 18, 2020
gzsombor added a commit to gzsombor/generator-jhipster-micronaut that referenced this issue Dec 22, 2020
@gzsombor
Copy link
Member

Thanks @pascalgrimaud ! I claimed the bug bounty here: https://opencollective.com/generator-jhipster/expenses/30439

@pascalgrimaud
Copy link
Member

@gzsombor : approved

coderguy-tech pushed a commit to coderguy-tech/generator-jhipster that referenced this issue Jun 1, 2021
…nt and PublicUserDTO for public consumptions
gzsombor added a commit to gzsombor/generator-jhipster-micronaut that referenced this issue Aug 9, 2022
gzsombor added a commit to gzsombor/generator-jhipster-micronaut that referenced this issue Aug 10, 2022
gzsombor added a commit to gzsombor/generator-jhipster-micronaut that referenced this issue Aug 16, 2023
gzsombor added a commit to gzsombor/generator-jhipster-micronaut that referenced this issue Aug 16, 2023
gzsombor added a commit to gzsombor/generator-jhipster-micronaut that referenced this issue Aug 17, 2023
gzsombor added a commit to gzsombor/generator-jhipster-micronaut that referenced this issue Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: enhancement 🔧 area: JHipster Code 💻 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: api theme: security $200 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

No branches or pull requests

3 participants