Skip to content

Commit

Permalink
Update to JHipster dependencies 3.0.0 stable release
Browse files Browse the repository at this point in the history
  • Loading branch information
@jdubois
jdubois committed Apr 4, 2019
1 parent 9fb5451 commit d3da18a
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 15 deletions.
2 changes: 0 additions & 2 deletions generators/server/templates/build.gradle.ejs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -259,8 +259,6 @@ repositories {
}
}
<%_ } _%>
// TODO To remove after final JHipster release
maven { url "http://oss.sonatype.org/content/repositories/snapshots" }
//jhipster-needle-gradle-repositories - JHipster will add additional repositories
}

Expand Down
2 changes: 1 addition & 1 deletion generators/server/templates/gradle.properties.ejs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ npm_version=<%= NPM_VERSION %>
yarn_version=<%= YARN_VERSION %>

# Dependency versions
jhipster_dependencies_version=3.0.0-SNAPSHOT
jhipster_dependencies_version=3.0.0
# The spring-boot version should match the one managed by
# https://mvnrepository.com/artifact/io.github.jhipster/jhipster-dependencies/${jhipster_dependencies_version}
spring_boot_version=2.1.4.RELEASE
Expand Down
13 changes: 1 addition & 12 deletions generators/server/templates/pom.xml.ejs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,17 +40,6 @@
</releases>
</repository>
<%_ } _%>
<!-- TODO To remove after final JHipster release -->
<repository>
<id>oss.sonatype.org-snapshot</id>
<url>http://oss.sonatype.org/content/repositories/snapshots</url>
<releases>
<enabled>false</enabled>
</releases>
<snapshots>
<enabled>true</enabled>
</snapshots>
</repository>
<!-- jhipster-needle-maven-repository -->
</repositories>

Expand Down Expand Up @@ -90,7 +79,7 @@
<profile.tls />

<!-- Dependency versions -->
<jhipster-dependencies.version>3.0.0-SNAPSHOT</jhipster-dependencies.version>
<jhipster-dependencies.version>3.0.0</jhipster-dependencies.version>
<!-- The spring-boot version should match the one managed by
https://mvnrepository.com/artifact/io.github.jhipster/jhipster-dependencies/${jhipster-dependencies.version} -->
<spring-boot.version>2.1.4.RELEASE</spring-boot.version>
Expand Down

12 comments on commit d3da18a

@DanielFran
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdubois @pascalgrimaud Should we now update bom to 3.0.1-SNAPSHOT and update generator to use it?
From the current experience we detect sooner if there is impacts due to the lack of builds in jhipster bom project...

@pascalgrimaud
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanielFran : yes, we can use master branch of JHipster dependencies. This afternoon, I suggested to Julien to use 'release' to be sure the build passed with the dependencies from Maven Central.

@DanielFran
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pascalgrimaud I have already the PR done for both projects.
Should I add again the reference to "oss.sonatype.org-snapshot"?

@pascalgrimaud
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need this, right ?

@DanielFran
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only if @jdubois create snapshots of jhipster-bom...

@DanielFran
Copy link
Member

@DanielFran DanielFran commented on d3da18a Apr 4, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is not automated, I do not know?
We can add it after...

@pascalgrimaud
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is still done manually, today :-)

@DanielFran
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So not needed for now!
I will merge PRs, and Julien can add it after if needed to users who do not want to compile jhipster-bom locally...

@jdubois
Copy link
Member Author

@jdubois jdubois commented on d3da18a Apr 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SNAPSHOTS can't be automated, as far as I know, as I need to sign them with PGP.
Anyway we're on a stable release now, there's no need to use SNAPSHOTS at the moment anymore.

@pvliss
Copy link
Contributor

@pvliss pvliss commented on d3da18a Apr 6, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdubois I was looking into this a couple of days got but never got a chance to mention that there is a way to actually automate the release of snapshots(as this has caused some issues during beta) and found the following very good articles on how to set this up:

I realize that this might be a bit more work to setup(although you may have done most of the work already) but believe it will eventually save you a lot of time in the future

@pascalgrimaud
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you said @pvliss, it's a lot of work to set up it correctly.

It was discussed long time ago, about splitting to jhipster-dependencies, because it will be less work for us, to maintain. Because it should be 'stable', no need to change it every day.

The more we work on the project, the more we have so synchronize between all different repos. In my opinion, it was less work when we were with mono repo, like suggested by @PierreBesson.

As @jdubois said :

Anyway we're on a stable release now, there's no need to use SNAPSHOTS at the moment anymore.

Can't we stay on stable release and wait feedback from users ?

@pvliss
Copy link
Contributor

@pvliss pvliss commented on d3da18a Apr 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well when I read the articles I thought that most of the steps should have already been done by @jdubois and it mainly is a matter of slightly modifying travis.yml and using tracis-cli to configure Travis properly but I might be terribly wrong :)

Agreed that using a released version is currently the easiest and fastest thing to do but it might be a problem again in the future when we need to avoid messing up with the stable release.

Anyways, you guys have way more experience than I do and I am sure you will choose what's best for the project. Simply wanted to note that it is possible to configure Travis for such a use case. If its worth it, is up for you to judge.

Please sign in to comment.